Skip to content

fix(stovepipe): Keep issues on task-wide failures - #958

Merged
prathshenoy merged 3 commits into
mainfrom
codex/stovepipe-taskwide-closure
Oct 27, 2026
Merged

prathshenoy merged 3 commits into
mainfrom
codex/stovepipe-taskwide-closure

Conversation

@prathshenoy

@prathshenoy prathshenoy commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Summary

What:

  • Keep existing issues open when any task-wide failure is recorded for a build.
  • Apply all reported issues before reconciling absent ones, using the existing processing phases.

Why:

  • Avoid treating missing target results as recovery. A task-wide failure can mean validation never ran or could not identify failed units, so closing earlier issues would claim recovery without evidence.
  • Avoid a separate precheck and new storage operations for data we already need to read. Recording task-wide failures while applying reported issues lets the closing pass use a decision established over the whole build.

Test Plan

  • Add unit tests.
  • Verify terminal intent and task-wide failure information persist against a real MySQL database.

Revert Plan

  • Revert this PR before enabling issue-tracking consumption. The added columns can remain unused; once consumption is enabled, drain active passes before rolling back.

Issue Links

Stack

  1. feat(stovepipe): Retain versioned issue state #942
  2. feat(stovepipe): Store applied issue state #948
  3. feat(stovepipe): Apply issue cursor updates #949
  4. feat(stovepipe): Track issues in bounded passes #950
  5. feat(stovepipe): Publish issue-tracking updates #951
  6. fix(stovepipe): Keep issues on task-wide failures #958
  7. feat(stovepipe): Recover failed issue tracking #961
  8. feat(stovepipe): Wire issue tracking consumers #962

@prathshenoy
prathshenoy force-pushed the codex/stovepipe-taskwide-closure branch from fa02eec to 0668840 Compare October 27, 2026 21:12
@prathshenoy
prathshenoy marked this pull request as ready for review October 27, 2026 21:15
@prathshenoy
prathshenoy added this pull request to the merge queue Oct 27, 2026
Merged via the queue into main with commit 125bea0 Oct 27, 2026
38 checks passed
Base automatically changed from codex/stovepipe-row-handoff to main October 27, 2026 21:59
@prathshenoy
prathshenoy deleted the codex/stovepipe-taskwide-closure branch October 27, 2026 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants