fix(registry): set floating toolbar placement to bottom on mobile to prevent overlap (#4619) - #5083
Open
Samarth1306w wants to merge 1 commit into
Open
Conversation
…prevent overlap (udecode#4619) On mobile screens (iOS Safari / Android Chrome), native selection context menus pop up above text selection. FloatingToolbar defaulting to placement: 'top' caused direct overlap. Fix: - Use useIsMobile hook in FloatingToolbar (floating-toolbar.tsx) to set placement: 'bottom' on mobile viewports. - Update fallbackPlacements to prioritize bottom placements on mobile. - Add patch changeset for www registry UI. Closes udecode#4619
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
🦋 Changeset detectedLatest commit: d65c65b The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dosubot
Bot
added
size:S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Summary
Fixes #4619 — 'floating toolbar' overlaps with native default 'context menu' in Mobile.
🔍 Root Cause Analysis
On mobile viewports (iOS Safari / Android Chrome), native selection context menus (Copy / Cut / Share) pop up directly above the text selection. Because
FloatingToolbarinapps/www/src/registry/ui/floating-toolbar.tsxdefaulted toplacement: 'top', custom floating toolbars collided and overlapped directly on top of native mobile context menus.🛠️ Surgical Patch Breakdown
apps/www/src/registry/ui/floating-toolbar.tsx:useIsMobilehook to setplacement: isMobile ? 'bottom' : 'top'.fallbackPlacementson mobile to prioritize bottom placements (['bottom-start', 'bottom-end', 'top-start', 'top-end'])..changeset/fix-floating-toolbar-mobile-placement-overlap.md: Added patch changeset for www registry UI.🧪 Verification & Test Coverage
mainwith 0 conflicts.