refactor: remove vestigial appRscStream handling from processRscComponents#166
Open
uhyo wants to merge 1 commit into
Open
refactor: remove vestigial appRscStream handling from processRscComponents#166uhyo wants to merge 1 commit into
uhyo wants to merge 1 commit into
Conversation
…nents processRscComponents accepted an appRscStream parameter and returned appRscContent, but its only caller (buildApp) passed a dummy empty stream and ignored the returned content — per-entry RSC payload replacement happens in buildSingleEntry via replaceIdsInContent. Drop the parameter and return field, delete the dummy-stream plumbing in buildApp, and assert on idMapping instead of appRscContent in the tests. Closes #148 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017tRZwdXQrksTxKMm4FUNp5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #148
Summary
processRscComponentsaccepted anappRscStreamparameter — draining it and applying the ID mapping to produceappRscContent— but its only caller,buildApp, passed a dummy empty stream and ignored the returned content. Per-entry RSC payload replacement actually happens inbuildSingleEntryviareplaceIdsInContent; the parameter and return field were leftovers from the single-entry design.Changes
rscProcessor.ts: drop theappRscStreamparameter and theappRscContentreturn field;processRscComponentsnow returns onlycomponentsandidMapping. The now-unuseddrainStreamimport is removed and step comments renumbered.buildApp.ts: delete the dummy-stream plumbing.rscProcessor.test.ts: remove thestreamOfhelper and assert onidMappinginstead ofappRscContent.Testing
pnpm typecheck,pnpm lint,pnpm format:check— cleanpnpm test:run— 102 unit tests pass🤖 Generated with Claude Code
https://claude.ai/code/session_017tRZwdXQrksTxKMm4FUNp5
Generated by Claude Code