Increase stellarator-helias epsfcn#4440
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4440 +/- ##
=======================================
Coverage 48.63% 48.63%
=======================================
Files 151 151
Lines 29673 29673
=======================================
Hits 14432 14432
Misses 15241 15241 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
My only concern would be that someone can try to use this regression test as template for other study and then start with 1e-2 as default option. But if you add a comment in the input file which explains that usually we start with 1e-3, then it is fine. |
Thanks for the reply @jjwalkowiak. I will add a comment. I suspect that some of the state remains over from the previous failed optimisation hence why the regression tests have changed. However, this optima will be just as valid as the previous solution, it is probably just closer to the initial point. Looking at the two solutions: This is so small that it does not even show up in the The only large changes to the solution are constraint residuals. These changing indicate that a different solution is being found, however this solution has near identical objective value and all the constraints are being satisfied. |
|
The reasoning for this change makes sense to me, so if @jjwalkowiak is happy I can merge it :) |
At the moment
stellarator-heliasdoes not converge within its first 100 iterations. PROCESS then automatically revises the epsfcn (step length for calculating derivatives) from1e-3to1e-2. Instead of waiting for this to happen automatically, I propose the input file is updated to reflect this.@jjwalkowiak what do you think?