Skip to content

fix(web): align registration license action buttons - #2101

Merged
Eli Bosley (elibosley) merged 1 commit into
mainfrom
codex/license-button-alignment
Oct 1, 2026
Merged

Eli Bosley (elibosley) merged 1 commit into
mainfrom
codex/license-button-alignment

Conversation

@elibosley

@elibosley Eli Bosley (elibosley) commented Oct 1, 2026 •

Copy link
Copy Markdown
Member

The registration Actions section repeats the Manage License label and places its button in a separate value column. This change removes that label and gives license actions a shared left edge and consistent button widths.

Uses a vertical action layout while preserving the existing button components, handlers, helper text, and disabled states. Other registration details retain their settings grid.

Work Intent: #2100

Validation: registration component suite passes (16 tests) on the branch based on current main; ESLint, Prettier, and git diff --check pass. Browser validation of the production build with fixture server data passes at desktop (1280px) and mobile (390px) widths: buttons share a left edge and width (300px desktop, 288px mobile), the duplicate label is absent, helper text stays below the button, and the trial TPM transfer action remains disabled. This validates presentation and disabled state; live Account and license-transfer flows were not exercised.

Summary by CodeRabbit

  • Style
    • Updated the registration actions area layout and width behavior.

@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: 8ee22ec3-93e8-4f47-b858-4f2f2aabf370

📥 Commits

Reviewing files that changed from the base of the PR and between d4d9733 and e8a2208.

📒 Files selected for processing (1)
  • web/src/components/Registration.standalone.vue

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.


Walkthrough

The registration component removes the manage-license onboarding label, sets KeyActions to maxWidth: true, and replaces the actions list’s SettingsGrid container with a flex-column container and a 4-unit gap.

Changes

Registration actions

Layer / File(s) Summary
Update registration actions
web/src/components/Registration.standalone.vue
The manage-license action no longer includes its onboarding label. KeyActions receives maxWidth: true. The actions list uses a flex-column container with a 4-unit gap.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to e8a22

The registration actions’ layout changes, while the manage-license control keeps its label and behavior. No material merge risk is evident from the supplied change context.

Architecture Summary

Architecture risk: 🔵 Low · up to e8a22

The change affects 1 system.

Changed systems: web

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — web (ui) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in web/src/components/Registration.standalone.vue: The manage-license action no longer includes its onboarding label.
  • observed — Modified behavior in web/src/components/Registration.standalone.vue: KeyActions now receives the maxWidth: true prop.
  • observed — Modified behavior in web/src/components/Registration.standalone.vue: The actions list container replaces SettingsGrid with a flex-column div using a 4-unit gap.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: aligning the registration license action buttons.
✨ Finishing Touches 💡 1
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checked the actions in a row,
Then gave the flex-column room to grow.
The license label hopped away,
maxWidth joined to shape the display.
Four units of gap, then off we go!

Comment @coderabbitai help to get the list of available commands.

@linear-code
linear-code Bot marked this pull request as ready for review October 1, 2026 22:37
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

This plugin has been deployed to Cloudflare R2 and is available for testing.
Download it at this URL:

https://preview.dl.unraid.net/unraid-api/tag/PR2101/dynamix.unraid.net.plg

@codecov

codecov Bot commented Oct 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.40%. Comparing base (d4d9733) to head (e8a2208).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2101      +/-   ##
==========================================
+ Coverage   53.38%   53.40%   +0.01%     
==========================================
  Files        1044     1044              
  Lines       72705    72705              
  Branches     8399     8401       +2     
==========================================
+ Hits        38811    38825      +14     
+ Misses      33767    33753      -14     
  Partials      127      127              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@elibosley
Eli Bosley (elibosley) merged commit b638d29 into main Oct 1, 2026
13 of 14 checks passed
@elibosley
Eli Bosley (elibosley) deleted the codex/license-button-alignment branch October 1, 2026 23:03
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

🔄 PR Merged - Plugin Redirected to Staging

This PR has been merged and the preview plugin has been updated to redirect to the staging version.

For users testing this PR:

  • Your plugin will automatically update to the staging version on the next update check
  • The staging version includes all merged changes from this PR
  • No manual intervention required

Staging URL:

https://preview.dl.unraid.net/unraid-api/dynamix.unraid.net.plg

Thank you for testing! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant