Repository navigation
chore: remove root renovate.json so the synced config applies - #16
Merged
Merged
Conversation
Renovate reads a root renovate.json before .github/renovate.json5, so the config synced from upbound/sa-up (gitops/shared-files/functions) was never used here. The root file has the same rules as the old synced config, so nothing is lost. Signed-off-by: Tobias Kässer <tobias.kasser@upbound.io>
jakubramut
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renovate reads a root
renovate.jsonbefore.github/renovate.json5, so the Renovate config synced from upbound/sa-up (gitops/shared-files/functions/renovate.json5) never takes effect in this repo.The root file carries the same rules as the previously synced config (crossplane examples group, gomod post-update options), so removing it loses nothing. After upbound/sa-up#607, the synced config also stops Renovate from bumping the synced workflows (
ci.yml,tag.yml) here; sa-up bumps them instead, so syncs no longer look like downgrades.