Repository navigation
test: cover Command.FlagNames parent lookup, Command.Count unknown-flag path, and HandleExitCoder direct ErrorFormatter - #2538
Open
Chris-cez wants to merge 1 commit into
Conversation
…ag path, and HandleExitCoder direct ErrorFormatter branch These three branches were exercised by existing fixtures only indirectly and showed up as uncovered in `go tool cover -func`. No production code changes; test-only additions to close the gaps.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Adds test-only coverage for three branches that were only exercised indirectly (or not at all) by the existing suite:
Command.FlagNamesmerging in parent command flag namesCommand.Countreturning0for an unknown flag nameHandleExitCoderhandling anErrorFormatter/ExitCoderpassed directly (not nested in aMultiError), which hits thefmt.Fprintf("%+v\n", err)branch — existing tests only exercised theMultiErrorpath viahandleMultiError'sfmt.FprintlnNo production code changes.
Which issue(s) this PR fixes:
Fixes #2537
Testing
Ran
go test ./...locally; all tests pass. Verified each new test fails if the corresponding branch is removed/broken.Release Notes