Repository navigation
fix: show a single required argument without a repeat marker in usage - #2539
Open
SudeepGowda55 wants to merge 1 commit into
Open
SudeepGowda55 wants to merge 1 commit into
SudeepGowda55 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
An
ArgumentsBasewithMin: 1, Max: 1accepts exactly one value, but its usage text wasname [name ...], which tells the user they can pass more. It now renders asname, the same as a required single-value argument.Which issue(s) this PR fixes:
None filed.
Testing
Updated the
onecase inTestArgsUsage(it was asserting the old output); it fails without the change.Release Notes