Repository navigation
秋新歓用ページを追加 - #355
Merged
Merged
秋新歓用ページを追加#355
Conversation
Deploying utcode-website with
|
| Latest commit: |
33f7707
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9b652f9c.utcode-website.pages.dev |
| Branch Preview URL: | https://docs--2026-autumn-welcome-ev.utcode-website.pages.dev |
aster-void
reviewed
Oct 8, 2026
aster-void
left a comment
Collaborator
There was a problem hiding this comment.
内容的には問題なさそう
- (この構造作ったの自分なのであれだけど)全データ新歓ページにインラインする方がフレキシブルになりそう
- 秋新歓時期にリンクを非表示にするのの理由がコメントにほしいかも! (既に終わってるからなら秋新歓だからではなくてそう書いてほしい)
Collaborator
それもあり |
Contributor
Author
|
データの構造云々の話は(もし気が向いたら)別のPRでやるかもしれません。 |
aster-void
approved these changes
Oct 8, 2026
aster-void
left a comment
Collaborator
There was a problem hiding this comment.
よさそう! (そもそも秋新歓やってないなら自分は更新する必要もないと思うけど、コンテキスト把握してないのでもしする方がよいという話なら)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
秋新歓用のページを別で作っておいて、リンクとパラメータだけ変えたらすぐに案内を開始できるようにしておくのがマニュアルとしては良さそうに感じた。