feat: adapt TimeLimit schema to query-lib Attribute and Index VOs - #124
Open
abnegate wants to merge 7 commits into
Open
feat: adapt TimeLimit schema to query-lib Attribute and Index VOs#124abnegate wants to merge 7 commits into
abnegate wants to merge 7 commits into
Conversation
Greptile SummaryThe PR adapts the database-backed time-limit schema to the query-lib collection, attribute, and index value objects while preserving the existing record and index structure.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (9): Last reviewed commit: "(chore): allow utopia-php/query 0.5" | Re-trigger Greptile |
utopia-php/database feat-query-lib (and Appwrite/Cloud) require PHP >=8.5. Advertising >=8.4.1 made Composer reject the graph for 8.4 consumers while CI only passed 8.4 via ignore-platform-reqs.
Member
Author
|
@greptile-apps review |
Schema setup with a known column or index type now uses Attribute::string() / Index::key() instead of the generic constructors plus ColumnType / IndexType.
Asterisk wildcards on utopia-php packages are replaced with equivalent caret constraints so Composer ranges stay consistent.
Keep composer.json and composer.lock in sync so `composer validate` passes, and pin utopia-php/database to the current query-lib HEAD.
Member
Author
|
@greptileai review |
This was referenced Aug 21, 2026
Member
Author
|
@greptile-apps review Force re-review of HEAD |
Database::createCollection no longer accepts a string id.
Database feat-query-lib now requires query ^0.5 after nested joins.
Member
Author
|
@greptile-apps review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required by appwrite/appwrite#11649 and appwrite-labs/cloud#5410 (
utopia-php/abuse: dev-feat-query-lib as 2.0.0). Depends on utopia-php/database#823.Why this approach
Query-lib
createCollection()takes aCollectionvalue object only. The TimeLimit adapter now callsnew Collection(id:, attributes:, indexes:)built from typed factories (Attribute::string(),Index::unique(), …) withColumnType/IndexType.Column set is unchanged:
key/time/count, unique(key, time)plustime.Composer pins
utopia-php/databasetodev-feat-query-lib as 7.0.0(808f90bf) with caret ranges (^not*).Verified
Not verified
ae8399dafter the Collection-only wraptests/Abuse/Appwrite/TablesDBTest.php) — needAPPWRITE_*CI secretsutopia-php/databasetag — stilldev-feat-query-libuntil database#823 merges