parser: track @namespace context in AST pretty-printing#66
Conversation
|
I was just finished working on this 🫠... I had said I was working on this issue. I went the hard route and just refactored everything not to use Display to avoid the thread_local and shenanigans. I ended up making a macro just for it not to explode in size tho. |
|
Let me at least salvage the tests... This frustrates me a lot because I really hate effort going to waste. Please, next time check out with people if you want to take issues that are assigned to them. Makes collaboration easier as well :) |
Alonely0
force-pushed
the
fix-issue#39-namespace-pretty-print
branch
from
a40a9fd to
b827a46
Compare
Identifiers are fully qualified at parse time, but Display was emitting awk:: prefixes and dropping @namespace directives. Pretty-print now tracks the active namespace, omits redundant qualifiers, restores @namespace for non-awk scopes, and fixes Delete debug formatting to use Debug for indices. Closed: uutils#39
Alonely0
force-pushed
the
fix-issue#39-namespace-pretty-print
branch
from
b827a46 to
a3a4b19
Compare
@Alonely0 Thank you for your review. I apologize. I will pay attention to this issue next time. I will communicate with you first before submitting my PR in the future. I apologize again. |
2 participants
Identifiers are fully qualified at parse time, but Display was emitting awk:: prefixes and dropping @namespace directives. Pretty-print now tracks the active namespace, omits redundant qualifiers, restores @namespace for non-awk scopes, and fixes Delete debug formatting to use Debug for indices.
Closed: #39