base64: don't drop already-decoded output when decoding hits invalid input#13314
Open
Chaganti-Reddy wants to merge 4 commits into
Open
base64: don't drop already-decoded output when decoding hits invalid input#13314Chaganti-Reddy wants to merge 4 commits into
Chaganti-Reddy wants to merge 4 commits into
Conversation
|
GNU testsuite comparison: |
Merging this PR will not alter performance
Comparing Footnotes
|
…e trailing remainder
7b62903 to
0fec3f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
base64 -d was throwing away everything it had already decoded whenever it hit invalid input later in the stream, instead of writing out the good prefix like GNU does. root cause was two spots that only flushed whole internal batches instead of whatever complete groups were actually buffered, plus base64's decoder rejecting a trailing group with non-canonical padding bits that GNU still accepts.
Fixes #12923