join: let -o accumulate fields across occurrences like GNU - #14070
Open
AlejandroCoronadoN wants to merge 1 commit into
Open
join: let -o accumulate fields across occurrences like GNU#14070AlejandroCoronadoN wants to merge 1 commit into
AlejandroCoronadoN wants to merge 1 commit into
Conversation
|
GNU testsuite comparison: |
Contributor
|
Please fix the conflict |
AlejandroCoronadoN
force-pushed
the
join-repeated-o-accumulate
branch
from
August 22, 2026 12:42
cfacabc to
a1e7a51
Compare
Contributor
Author
|
Fixed the conflict, rebased onto current main (the change now sits on top of the new -o caret diagnostics). Thanks! |
cakebaker
reviewed
Aug 23, 2026
| } | ||
|
|
||
| #[test] | ||
| fn repeated_o_ignores_auto_when_mixed() { |
Contributor
There was a problem hiding this comment.
This test is a bit unlucky as both -o auto and -o 1.1 2.2 on their own have the same output and so, when combined, you can't say which option got ignored. I would use a different format for the second option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GNU
joinlets-o FORMATappear more than once; the field specs from every occurrence accumulate in order. uutils rejects a repeated-owith a hard error:This makes several
-oaccumulate, matching GNU, including theautocorner cases:automode applies only when every-ovalue is exactlyauto, otherwise eachautois ignored and the real specs accumulate. It uses the existingArgAction::Appendidiom (as-aand-valready do). Single--obehavior and the per-field diagnostics are unchanged.