Replace filetime with std::fs timestamp APIs - #14087
Draft
wtcpython wants to merge 1 commit into
Draft
Conversation
|
GNU testsuite comparison: |
oech3
reviewed
Aug 23, 2026
| rustflags = ["-C", "target-feature=+crt-static"] | ||
|
|
||
| [env] | ||
| RUSTC_BOOTSTRAP = "1" |
Contributor
There was a problem hiding this comment.
I strongly disagree with adding such hack. (Maybe, breaking crate.io). If you need nightly API to remove the dep, you are probably using incorrect API.
Contributor
|
The method |
oech3
reviewed
Aug 23, 2026
| .set_accessed(source_metadata.accessed()?) | ||
| .set_modified(source_metadata.modified()?); | ||
|
|
||
| if dest.is_symlink() { |
Contributor
There was a problem hiding this comment.
We can open dest as File with NOFOLLOW and use method on unix. I don't know any alt for Windows and wasi (or copy code from nightly std to uucore).
Contributor
|
Is it necessary to bump |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the
filetimecrate withstd::fs::set_timesandstd::fs::set_times_nofollow.Rust 1.99 is currently beta, so
RUSTC_BOOTSTRAPand the feature gate aretemporary and can be removed once 1.99 is stable.
All relevant tests pass.
Fixes #13808