tail: do not abort on -c +N when the start offset is past the seek limit - #14091
Open
SAY-5 wants to merge 1 commit into
Open
tail: do not abort on -c +N when the start offset is past the seek limit#14091SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
|
GNU testsuite comparison: |
Merging this PR will degrade performance by 3.02%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | du_wide_tree[(5000, 500)] |
19.4 ms | 20 ms | -3.02% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing SAY-5:tail-fix-seek-past-limit (2466ccd) with main (9875296)
Footnotes
-
50 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13887.
tail -c +Non a regular file larger than the block size seeks to byteN-1. When that offset is past the largest seekable position the underlyinglseekreturnsEINVAL, and the.unwrap()aborted the process (exit 134). GNU treats a start byte past the end of the file as empty output.This falls back to seeking to the end of the file when the initial seek fails, mirroring the existing handling in the negative-bytes arm, so the request produces no output instead of crashing.
Added a regression test that runs
tail -c +<huge> FILEon a file larger than the block size and expects success with empty output.