split: avoid arithmetic overflow on a huge numeric or hex suffix start value - #14092
Open
SAY-5 wants to merge 1 commit into
Open
split: avoid arithmetic overflow on a huge numeric or hex suffix start value#14092SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
…t value Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
Merging this PR will improve performance by 3.76%
Performance Changes
Tip Curious why this is faster? Comment Comparing Footnotes
|
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13749.
When
splitauto-computes the suffix length it adds the suffix start value (--numeric-suffixes=N/--hex-suffixes=N) to the chunk count asstart as u64 + chunks. A start value nearu64::MAXoverflows that add and panics withattempt to add with overflowunder overflow checks (exit 134).This uses
saturating_addso the auto-width calculation no longer overflows; an out-of-range start value now flows into the existing suffix-length error instead of aborting.Added regression tests for
--numeric-suffixesand--hex-suffixesstart values nearu64::MAX.