validate.rs: extract actual error message from OS - #14098
Open
oech3 wants to merge 1 commit into
Open
Conversation
Merging this PR will improve performance by 3.95%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | du_summarize_balanced_tree[(5, 4, 10)] |
16.8 ms | 16 ms | +4.59% |
| ⚡ | Simulation | cksum_sysv |
68.4 ms | 65.7 ms | +4.16% |
| ⚡ | Simulation | cksum_crc32b |
39.7 ms | 38.5 ms | +3.11% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing oech3:cksum-err (4fee4df) with main (0aeda8f)
Footnotes
-
50 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
oech3
force-pushed
the
cksum-err
branch
3 times, most recently
from
August 23, 2026 13:58
bc42fdf to
4fee4df
Compare
oech3
marked this pull request as ready for review
August 23, 2026 13:58
|
GNU testsuite comparison: |
Contributor
|
is it really worse the added complexity? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.