Skip to content

validate.rs: extract actual error message from OS - #14098

Open
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:cksum-err
Open

validate.rs: extract actual error message from OS#14098
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:cksum-err

Conversation

@oech3

@oech3 oech3 commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@oech3
oech3 marked this pull request as draft August 23, 2026 13:31
@codspeed-hq

codspeed-hq Bot commented Aug 23, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 3.95%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 3 improved benchmarks
✅ 354 untouched benchmarks
⏩ 50 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation du_summarize_balanced_tree[(5, 4, 10)] 16.8 ms 16 ms +4.59%
Simulation cksum_sysv 68.4 ms 65.7 ms +4.16%
Simulation cksum_crc32b 39.7 ms 38.5 ms +3.11%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing oech3:cksum-err (4fee4df) with main (0aeda8f)

Open in CodSpeed

Footnotes

  1. 50 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@oech3
oech3 force-pushed the cksum-err branch 3 times, most recently from bc42fdf to 4fee4df Compare August 23, 2026 13:58
@oech3
oech3 marked this pull request as ready for review August 23, 2026 13:58
@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/cut/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/date/resolution (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/cut/cut-huge-range is now being skipped but was previously passing.

@sylvestre

Copy link
Copy Markdown
Contributor

is it really worse the added complexity?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants