Skip to content

install, comm: remove file_diff in favor of uucore::fs::are_files_identical - #14113

Merged
sylvestre merged 1 commit into
uutils:mainfrom
wtcpython:remove-file-diff
Aug 24, 2026
Merged

install, comm: remove file_diff in favor of uucore::fs::are_files_identical#14113
sylvestre merged 1 commit into
uutils:mainfrom
wtcpython:remove-file-diff

Conversation

@wtcpython

Copy link
Copy Markdown
Contributor

Remove unmaintained file_diff dependency.

Moves are_files_identical from uu_comm to uucore::fs, and uses it in uu_install's need_copy.

@github-actions

github-actions Bot commented Aug 24, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/tail/tail-n0f is now being skipped but was previously passing.

@codspeed-hq

codspeed-hq Bot commented Aug 24, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 357 untouched benchmarks
⏩ 50 skipped benchmarks1


Comparing wtcpython:remove-file-diff (9364607) with main (8b8cbfd)

Open in CodSpeed

Footnotes

  1. 50 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Comment thread src/uucore/src/lib/features/fs.rs
@sylvestre

Copy link
Copy Markdown
Contributor

LGTM, thanks

@sylvestre
sylvestre enabled auto-merge (rebase) August 24, 2026 11:25
@sylvestre
sylvestre merged commit 18f8874 into uutils:main Aug 24, 2026
171 checks passed
@wtcpython
wtcpython deleted the remove-file-diff branch August 24, 2026 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants