chore: remove unused Tokens convenience wrappers - #1168
Closed
theredspoon wants to merge 1 commit into
Closed
Conversation
File.Tokens and TokenCache.Tokens wrap TokensWith with an empty model name but have no callers anywhere in the codebase; TokensWith itself is what every check type actually uses.
Author
|
Closing this as it's a standalone dead-code removal, which the new CONTRIBUTING.md guidelines say gets closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
File.TokensandTokenCache.Tokensare convenience wrappers aroundTokensWith(with an empty model name) that have no callers anywhere in the codebase.TokensWithitself is what every check type actually uses.Fix
Removed both. No behavior change.
Testing
Full repo suite and
-raceare clean.Related
Found during review of #1162. Split out here as an independent cleanup per the smaller-PR preference from #938.