Skip to content

fix(merge): validators mutate the caller's options object - #2848

Open
rajanpanth wants to merge 1 commit into
validatorjs:masterfrom
rajanpanth:fix/merge-mutates-options
Open

fix(merge): validators mutate the caller's options object#2848
rajanpanth wants to merge 1 commit into
validatorjs:masterfrom
rajanpanth:fix/merge-mutates-options

Conversation

@rajanpanth

Copy link
Copy Markdown

Diagnosed and fixed with AI assistance (Claude). merge() wrote defaults into the passed-in options object (also throwing on a frozen object); see commit.

@codecov

codecov Bot commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (cdb7daf) to head (0edaa40).

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2848   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          114       114           
  Lines         2599      2598    -1     
  Branches       658       658           
=========================================
- Hits          2599      2598    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rajanpanth

Copy link
Copy Markdown
Author

Friendly follow-up on this PR 👋

When you have a moment, could you please take a look? I’m happy to update anything if needed.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant