Skip to content

fix(isMailtoURI): decode recipient addresses before validation #2923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FanWu-ai wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(isMailtoURI): decode recipient addresses before validation #2923

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/lib/isMailtoURI.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ import trim from './trim';
import isEmail from './isEmail';
import assertString from './util/assertString';

const recipientControlCharacters = /[\x00-\x1F\x7F]/; // eslint-disable-line no-control-regex

function parseMailtoQueryString(queryString) {
const allowedParams = new Set(['subject', 'body', 'cc', 'bcc']),
query = { cc: '', bcc: '' };
Expand Down Expand Up @@ -59,7 +61,12 @@ export default function isMailtoURI(url, options) {
email = trim(email, ' ');

if (email) {
return isEmail(email, options);
try {
email = decodeURIComponent(email);
} catch (e) {
return false;
}
return !recipientControlCharacters.test(email) && isEmail(email, options);
}

return true;
Expand Down
69 changes: 69 additions & 0 deletions test/validators.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16177,6 +16177,75 @@ describe('Validators', () => {
],
});
});
it('should decode percent-encoded mailto URI recipients', () => {
test({
validator: 'isMailtoURI',
valid: [
'mailto:user@%E7%B4%8D%E8%B1%86.example.org?subject=Test&body=NATTO',
'mailto:?cc=user@%E7%B4%8D%E8%B1%86.example.org',
'mailto:?bcc=user@%E7%B4%8D%E8%B1%86.example.org',
'mailto:user@%E7%B4%8D%E8%B1%86.example.org,other@example.com',
'mailto:%22last%2Cfirst%22@example.com',
'mailto:gorby%25kremvax@example.com',
'mailto:literal%2520name@example.com',
'mailto:bill+ietf@example.org',
'mailto:bill%2Bietf@example.org',
],
invalid: [
'mailto:foo%20bar@example.com',
'mailto:?cc=foo%20bar@example.com',
'mailto:?bcc=foo%20bar@example.com',
'mailto:foo%00bar@example.com',
'mailto:foo%0D%0Abar@example.com',
],
});
});

it('should reject malformed percent-encoding in mailto URI recipients', () => {
test({
validator: 'isMailtoURI',
invalid: [
'mailto:foo%@example.com',
'mailto:foo%2@example.com',
'mailto:foo%GG@example.com',
'mailto:foo%C3%28@example.com',
'mailto:?cc=foo%@example.com',
'mailto:?bcc=foo%GG@example.com',
],
});
});

it('should reject decoded controls in quoted mailto URI recipients', () => {
const recipients = ['%00', '%01', '%09', '%0A', '%0D%0A', '%1F', '%7F']
.map(control => `%22first${control}last%22@%65xample.com`);

[true, false].forEach((allowUtf8) => {
test({
validator: 'isMailtoURI',
args: [{ allow_utf8_local_part: allowUtf8 }],
invalid: recipients.map(email => `mailto:${email}`)
.concat(recipients.map(email => `mailto:?cc=${email}`))
.concat(recipients.map(email => `mailto:?bcc=${email}`)),
});
});
});

it('should apply email options to decoded mailto URI recipients', () => {
test({
validator: 'isMailtoURI',
args: [{ allow_utf8_local_part: false }],
valid: [
'mailto:user@%E7%B4%8D%E8%B1%86.example.org',
'mailto:bill%2Bietf@example.org',
],
invalid: [
'mailto:andr%C3%A9@example.com',
'mailto:?cc=andr%C3%A9@example.com',
'mailto:?bcc=andr%C3%A9@example.com',
],
});
});

it('should validate mailto URI', () => {
test({
validator: 'isMailtoURI',
Expand Down