Repository navigation
Conversation
FanWu-ai
marked this pull request as ready for review
October 10, 2026 21:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isNumericcurrently builds a character class containingundefinedwhen given a locale absent from the decimal-separator table. For example,isNumeric('12d34', { locale: 'de-CH' })andisNumeric('n1', { locale: 'de-CH' })both returntrue, while ordinary3.5returnsfalse.Reject unknown locale options, including inherited object-property names, before building that expression, following
isDecimal, which reads the same separator table and already throwsInvalid locale 'de-CH'. This does not add support forde-CH. Theno_symbolspath continues to ignore the locale because it does not use a decimal separator. The README documents the error behavior.Validation (Node.js 24.19.0):
isNumeric("n1", {"locale":"de-CH"}) passed but should error.npm test: 323 passing.npm test: 325 passing; all generated builds and ESLint passed; statements, lines, and functions remain at 100% coverage.git diff --checkpassed.Tests ran with HOME and npm cache redirected to writable temporary directories. No checks were disabled.
Prepared with OpenAI Codex. The reproduction and local checks above were executed in the development environment.
Checklist
isDecimalbehavior used as the error-handling precedent