Skip to content

fix(isIn): check object membership without calling shadowed methods #2929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FanWu-ai wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(isIn): check object membership without calling shadowed methods #2929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/isIn.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export default function isIn(str, options) {
}
return array.indexOf(str) >= 0;
} else if (typeof options === 'object') {
return options.hasOwnProperty(str);
return Object.prototype.hasOwnProperty.call(options, str);
} else if (options && typeof options.indexOf === 'function') {
return options.indexOf(str) >= 0;
}
Expand Down
33 changes: 33 additions & 0 deletions test/validators.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6184,6 +6184,39 @@ describe('Validators', () => {
});
});

it('should validate membership in objects with no prototype', () => {
const values = Object.create(null);
values.foo = 1;
values.bar = 2;
test({
validator: 'isIn',
args: [values],
valid: ['foo', 'bar'],
invalid: ['missing', 'toString', 'constructor', ''],
});
});

it('should validate membership when hasOwnProperty is an object key', () => {
test({
validator: 'isIn',
args: [{ foo: 1, hasOwnProperty: 2 }],
valid: ['foo', 'hasOwnProperty'],
invalid: ['missing', 'toString', 'constructor', ''],
});
});

it('should not call an object membership value as hasOwnProperty', () => {
const values = Object.create({ inherited: 1 });
values.foo = 1;
values.hasOwnProperty = () => true;
test({
validator: 'isIn',
args: [values],
valid: ['foo', 'hasOwnProperty'],
invalid: ['missing', 'inherited', 'toString', ''],
});
});

it('should validate ABA routing number', () => {
test({
validator: 'isAbaRouting',
Expand Down