Skip to content

perf(isEmail, isFQDN, normalizeEmail): up to 2x faster by skipping the default-options copy #2932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deadstrobe5 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

perf(isEmail, isFQDN, normalizeEmail): up to 2x faster by skipping the default-options copy #2932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/isEmail.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ function validateDisplayName(display_name) {

export default function isEmail(str, options) {
assertString(str);
options = merge(options, default_email_options);
options = options ? merge(options, default_email_options) : default_email_options;

if (options.require_display_name || options.allow_display_name) {
const display_email = str.match(splitNameAddress);
Expand Down
2 changes: 1 addition & 1 deletion src/lib/isFQDN.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const default_fqdn_options = {

export default function isFQDN(str, options) {
assertString(str);
options = merge(options, default_fqdn_options);
options = options ? merge(options, default_fqdn_options) : default_fqdn_options;

/* Remove the optional trailing dot before checking validity */
if (options.allow_trailing_dot && str[str.length - 1] === '.') {
Expand Down
4 changes: 3 additions & 1 deletion src/lib/normalizeEmail.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,9 @@ function dotsReplacer(match) {
}

export default function normalizeEmail(email, options) {
options = merge(options, default_normalize_email_options);
options = options
? merge(options, default_normalize_email_options)
: default_normalize_email_options;

const raw_parts = email.split('@');
const domain = raw_parts.pop();
Expand Down
Loading