tests(config-variations): Git schemes in repo URLs#426
Conversation
30b561b to
8075ac0
Compare
8075ac0 to
29167fd
Compare
206715e to
0f25cdd
Compare
f0359d6 to
7c14a3b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #426 +/- ##
==========================================
- Coverage 78.98% 78.98% -0.01%
==========================================
Files 8 9 +1
Lines 414 452 +38
Branches 85 94 +9
==========================================
+ Hits 327 357 +30
- Misses 52 57 +5
- Partials 35 38 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fdfabb9 to
d270f39
Compare
d270f39 to
530c10e
Compare
Related to vcs-python/vcspull#49, vcs-python/vcspull#426 **In main repo URLs:** Main repo URLs require `libvcs.url.git.GitURL` support: Scheme: `user@domain.tld:org/repo.git` Example: `git@github.com:tmux-python/tmuxp.git` Note: The workaround is to prepend `git+ssh://git@github.com:tmux-python/tmuxp.git`
530c10e to
b99735a
Compare
why: - Previously, enabling SSH-style URL detection mutated libvcs’s DEFAULT_RULES on import and lost the rule’s original metadata. - Users couldn’t cleanly disable the patch or restore upstream defaults if libvcs changed. - Implicit module-import side-effects are harder to reason about. what: - Introduce private `_orig_rule_meta` to snapshot rule’s original metadata. - Store original metadata on first enable and apply `(True, 100)`. - Restore saved metadata (or safe defaults) on disable, clearing snapshot. - Remove auto-patch on import; require explicit call. - Add `ssh_style_url_detection` context manager. - Call `enable_ssh_style_url_detection()` in `update_repo()` to maintain behavior. - Add pytest tests for enable/disable roundtrip and context manager.
b99735a to
1f39d80
Compare
|
Closing — the feature is obsolete, fixed upstream in libvcs. This PR added a On current libvcs that rule already ships
Re-authoring would only add a no-op patch that mutates libvcs's global rule objects — fragile shared state for zero behavior change. SSH-style config URLs work today without it. Closing as superseded; if a regression guard is wanted, a small test asserting |
Fixes #49
In main repo URLs:
Main repo URLs require
libvcs.url.git.GitURLsupport:Scheme:
user@domain.tld:org/repo.gitExample:
git@github.com:tmux-python/tmuxp.gitFor remote URLs, see #419
Note: The workaround is to prepend
git+ssh://git@github.com:tmux-python/tmuxp.git