docs: fix 5 typos in comments and log messages - #12
Open
Avicennasis wants to merge 1 commit into
Open
Avicennasis wants to merge 1 commit into
Avicennasis wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix 5 typos across 5 files - four in log/comment text and one in a label description.
cancelPipeline()logged"Error while fetching pipeline variable", copy-pasted fromgetPipelineVariables()eleven lines above ->"Error while canceling pipeline". The genuine occurrence at L158 insidegetPipelineVariables()is left as-is.with the fist of (possible) multiple flaws->firstError while retriving application details->retrievingremove sandbox scan failed becasue sourceBranch not found->because'A Veracode Flaw,Unknown severity'was missing the space after the comma. The other six severity entries in the same object all read'A Veracode Flaw, <X> severity'.Notes for reviewers
service.jschange is the only one that alters a message a user might grep for. It is aconsole.login acatchblock; nothing in the repository asserts on the string, and the copy-paste made the cancel path report a misleading error.labels.jsdescriptionis only sent when a label is created;checkLabelExistsmatches onname, so the added space does not affect label lookup.retrivingalso appears inveracode-scans/policy-scan/policy.js(L139, L141) andutility/common.js(L79). Those were outside the scope of this pass and are left untouched - happy to fold them in if you would prefer a single sweep.package.jsondeclares"license": "ISC", but alongside an empty"description"and"author"that reads more like an uneditednpm initdefault than a deliberate grant. There is no explicit licence covering outside contributions. We noticed and wanted to flag it rather than assume - adding a LICENSE file would make things clearer for future contributors.No functional changes - comments, log messages and one label description only.