fix(confirmation): derive approval type from AI SDK ToolUIPart - #488
Open
ShobhanKarthish wants to merge 1 commit into
Open
fix(confirmation): derive approval type from AI SDK ToolUIPart#488ShobhanKarthish wants to merge 1 commit into
ShobhanKarthish wants to merge 1 commit into
Conversation
Replace the hand-copied ToolUIPartApproval union with NonNullable<ToolUIPart['approval']> so the Confirmation component stays aligned with the SDK. Surface approval.requestReason in ConfirmationRequest when the field is present. Closes vercel#484
Contributor
|
@ShobhanKarthish is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
|
|
||
| export const ConfirmationRequest = ({ children }: ConfirmationRequestProps) => { | ||
| const { state } = useConfirmation(); | ||
| const { approval, state } = useConfirmation(); |
Contributor
There was a problem hiding this comment.
ConfirmationRequest's requestReason rendering is dead code because the pinned ai v6 dependency never emits a requestReason field on the approval-requested approval object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ToolUIPartApprovalunion inconfirmation.tsxwithNonNullable<ToolUIPart['approval']>so the Confirmation approval shape stays aligned with the AI SDK.approval.requestReasoninConfirmationRequestwhen that field is present, so explanations for why a tool call needs human review are visible without casting.requestReasonrendering.Closes #484
Test plan
vitest run __tests__/confirmation.test.tsx(18 tests passed)requestReasonis absentrequestReason, confirm the reason appears in the request UI