Skip to content

chore(changeset): trim the route-groups changeset to one line - #4143

Merged
pranaygp merged 1 commit into
mainfrom
triage-workflow3991-changeset-trim
Sep 12, 2026
Merged

chore(changeset): trim the route-groups changeset to one line#4143
pranaygp merged 1 commit into
mainfrom
triage-workflow3991-changeset-trim

Conversation

@pranaygp

@pranaygp pranaygp commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #4070 (merged as d427c47) — no code change, one changeset file.

What happened

You left this review comment on #4070's changeset: "too verbose. let's just have the 1 line here since this will go into changelog and we don't need all the paragraphs below."

I fixed it on #4140, the CI mirror of #4070 — but #4070 is the one that merged and #4140 was closed, so the trim went with it. Nothing went wrong in the merge; the fix was just sitting on the wrong PR. (Good outcome otherwise: merging #4070 means @torsello kept authorship.)

Why the changeset file is still the right place to fix it

The changeset has not been consumed yet — it's still at .changeset/workflow-name-nextjs-route-segments.md on main, and packages/core/CHANGELOG.md contains none of this text. The open release PR #4142 has it staged (renames to .changeset/pre/… and writes the long version into the changelog), and it regenerates on every push to main, so landing this will refresh #4142 with the one-liner. No changelog surgery needed, and nothing has been published with the verbose text.

Before / after

-Allow parentheses and square brackets in workflow names
-
-A workflow name is derived from the module path it is defined in, so Next.js App
-Router conventions end up in the name verbatim. `SAFE_WORKFLOW_NAME_PATTERN` did
-not permit `(`, `)`, `[` or `]`, so any workflow inside a route group
-(`app/(dashboard)/…`) or a dynamic segment (`app/[teamId]/…`, `app/[...slug]/…`)
-threw `Invalid workflow name` before it could be enqueued, with no way to
-override the generated name.
-
-These characters are inert in the queue name the pattern guards: `ValidQueueName`
-already accepts any suffix after its prefix, and the name is never interpolated
-into a URL or a SQL identifier.
+Allow parentheses and square brackets in workflow names, so workflows can live in Next.js route groups (`app/(dashboard)/…`) and dynamic segments (`app/[teamId]/…`).

Also lost with #4140

The world-vercel test from #4140 didn't land either — the one pinning that a workflow name still reaches VQS as a valid topic ([A-Za-z0-9_-]) after prepareSend folds it. That guarantee is what makes the parens/brackets fix safe on the Vercel world, and it's still untested. Deliberately not included here to keep this mergeable on sight; happy to send it as its own PR.

PR Checklist - Required to merge

  • 📦 Changeset — this PR is the changeset edit; no new one needed (a chore on an unconsumed changeset produces no release of its own)
  • 🔒 DCO sign-off
  • 📝 Ping @vercel/workflow

🤖 Generated with Claude Code

The changeset body is copied verbatim into the changelog, where the
rationale paragraphs from #4070 are noise. Keep the line that says what
changed and where it matters; the reasoning is already in the commit,
the PR and issue #3991.

This was reviewed on #4070 and fixed on #4140, a CI mirror of that PR.
#4070 is the one that merged and #4140 was closed, so the fix never
landed. The changeset is still unconsumed on `main`, so correcting the
file is enough — the open release PR regenerates from it and no
CHANGELOG.md has been written yet.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Signed-off-by: Pranay Prakash <1797812+pranaygp@users.noreply.github.com>

Co-Authored-By: Pranay Prakash <1797812+pranaygp@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings September 12, 2026 05:00
@pranaygp
pranaygp requested a review from a team as a code owner September 12, 2026 05:00
@changeset-bot

changeset-bot Bot commented Sep 12, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: b3ec09f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 16 packages
Name Type
@workflow/core Patch
@workflow/builders Patch
@workflow/cli Patch
@workflow/next Patch
@workflow/nitro Patch
@workflow/vitest Patch
@workflow/web-shared Patch
@workflow/web Patch
workflow Patch
@workflow/world-testing Patch
@workflow/astro Patch
@workflow/nest Patch
@workflow/rollup Patch
@workflow/sveltekit Patch
@workflow/vite Patch
@workflow/nuxt Patch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercel Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
example-nextjs-workflow-turbopack Ready Ready Preview, v0 Sep 12, 2026 5:04am UTC
example-nextjs-workflow-webpack Ready Ready Preview, v0 Sep 12, 2026 5:04am UTC
example-workflow Ready Ready Preview, v0 Sep 12, 2026 5:04am UTC
workbench-astro-workflow Ready Ready Preview, v0 Sep 12, 2026 5:04am UTC
workbench-express-workflow Ready Ready Preview, v0 Sep 12, 2026 5:04am UTC
workbench-fastify-workflow Ready Ready Preview, v0 Sep 12, 2026 5:04am UTC
workbench-hono-workflow Ready Ready Preview, v0 Sep 12, 2026 5:04am UTC
workbench-nestjs-workflow Ready Ready Preview, v0 Sep 12, 2026 5:04am UTC
workbench-nitro-workflow Ready Ready Preview, v0 Sep 12, 2026 5:04am UTC
workbench-nuxt-workflow Ready Ready Preview, v0 Sep 12, 2026 5:04am UTC
workbench-python-workflow Ready Ready Preview, v0 Sep 12, 2026 5:04am UTC
workbench-sveltekit-workflow Ready Ready Preview, v0 Sep 12, 2026 5:04am UTC
workbench-tanstack-start-workflow Ready Ready Preview, v0 Sep 12, 2026 5:04am UTC
workbench-vite-workflow Ready Ready Preview, v0 Sep 12, 2026 5:04am UTC
workflow-docs Ready Ready Preview, v0 Sep 12, 2026 5:04am UTC
workflow-swc-playground Ready Ready Preview, v0 Sep 12, 2026 5:04am UTC
workflow-tarballs Ready Ready Preview, v0 Sep 12, 2026 5:04am UTC
workflow-web Ready Ready Preview, v0 Sep 12, 2026 5:04am UTC

@github-actions

Copy link
Copy Markdown
Contributor

Sim World

Simulated world deterministic testing for races. Traces

🟠 world-sim scenario book — 1 fail of 41 total

fence=per-spec

scenario outcome events virt replay violations
smoke-no-steps completed 3 0ms ok 0
smoke-one-step completed 6 0ms ok 0
hook-at-step-started completed 12 0ms ok 0
hook-at-step-completed completed 12 0ms ok 0
hook-at-hook-created completed 12 0ms ok 0
deadline-hook-wins completed 7 1.0h ok 0
deadline-expires completed 7 1.0h ok 0
long-sleep completed 11 30.0d ok 0
hook-never-arrives stalled 3 0ms skipped 0
step-retries-twice completed 10 2.0s ok 0
parallel-steps completed 9 0ms ok 0
hook-on-execution-state completed 12 0ms ok 0
peek-hook-before-branch completed 12 0ms ok 0
peek-hook-after-branch completed 12 0ms ok 0
peek-hook-at-registration completed 12 0ms ok 0
race-hook-before-probe completed 12 0ms ok 0
race-hook-after-probe completed 12 0ms ok 0
race-duplicate-delivery completed 13 0ms ok 0
attr-hook-before-step completed 11 0ms ok 0
attr-hook-after-step completed 11 0ms ok 0
attr-from-step-body completed 13 0ms ok 0
fork-hook-after-timeout completed 14 1.0m ok 0
fork-hook-before-timeout completed 14 1.0m ok 0
count-hook-after-timeout completed 17 1.0m ok 0
count-hook-before-timeout completed 20 1.0m ok 0
stale-read-step-count-fork completed 20 1.0m ok 0
stale-read-equal-step-counts completed 14 1.0m ok 0
step-vs-step-fork completed 12 0ms ok 0
step-vs-step-fork-fenced completed 12 0ms ok 0
fence-catches-benign-direction completed 12 5ms ok 0
in-flight-before-decision completed 17 1.0m ok 0
in-flight-before-decision-counted completed 17 1.0m ok 0
in-flight-after-decision completed 19 2.0m ok 0
stale-read-step-count-fork-fenced completed 20 1.0m ok 0
fork-hook-wins completed 13 1.0m ok 0
fork-timeout-wins completed 13 1.0m ok 0
unclaimed-payload-under-fork completed 17 1.0m ok 0
claimed-payload-under-fork completed 17 1.0m ok 0
writers-independent-step-bodies completed 12 0ms ok 0
writers-scripted-tempo completed 12 0ms ok 0
cancel-mid-step cancelled 7 0ms skipped 0

Full trace: world-sim.txt

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The reviewed change only shortens the unconsumed changeset entry and has no unresolved review comments.

Pull request overview

This PR trims the pending @workflow/core changeset to a concise one-line changelog entry without code changes.

Changes:

  • Replaces the verbose explanation with a single sentence.
  • Preserves package and patch metadata.
File summaries
File Description
.changeset/workflow-name-nextjs-route-segments.md Concise description of the workflow-name fix
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@pranaygp
pranaygp merged commit b360cb4 into main Sep 12, 2026
68 checks passed
@pranaygp
pranaygp deleted the triage-workflow3991-changeset-trim branch September 12, 2026 05:09
@github-actions

Copy link
Copy Markdown
Contributor

No backport to stable for b360cb4 (AI decision).

This commit touches only .changeset/workflow-name-nextjs-route-segments.md, trimming the changeset prose for an already-merged fix. Changeset-only edits are release plumbing with no code, test, or user-facing behavior impact, and the underlying fix would be carried by its own backport if warranted.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

b360cb4d8d2dbb57bf379c2acef4ae9b63b508c4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants