Skip to content

fix(content-pages): return false for exists endpoint when 404 exception #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bertyhell wants to merge 1 commit into
base: release/v6.0.0
Choose a base branch
from
+33 −11
Open

fix(content-pages): return false for exists endpoint when 404 exception #384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 33 additions & 11 deletions api/src/modules/content-pages/controllers/content-pages.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import {
Delete,
ForbiddenException,
Get,
InternalServerErrorException,
Ip,
NotFoundException,
Param,
Expand Down Expand Up @@ -122,13 +121,23 @@ export class ContentPagesController {
onlyInfo === 'true'
);
if (!contentPage) {
throw new CustomError('ContentPage not found', null, {code: 'NOT_FOUND'}, 404);
throw new CustomError('ContentPage not found', null, { code: 'NOT_FOUND' }, 404);
}
return contentPage;
// biome-ignore lint/suspicious/noExplicitAny: error can be any type
} catch (err: any) {
if (err?.response?.additionalInfo?.code === 'NOT_FOUND' || err?.statusCode === 404) {
throw new NotFoundException('The content page with path was not found');
throw new CustomError(
'The content page with path was not found',
err,
{
language,
path,
onlyInfo,
code: 'NOT_FOUND',
},
404
);
}
const error = new CustomError('Failed to get content page by language and path', err, {
language,
Expand All @@ -151,14 +160,27 @@ export class ContentPagesController {
@Ip() ip: string,
@SessionUser() user: SessionUserEntity
): Promise<{ exists: boolean; title: string; id: number | string }> {
const contentPage = await this.getContentPageByLanguageAndPath(
language,
path,
'true',
request,
ip,
user
);
let contentPage: DbContentPage | null = null;
try {
contentPage = await this.getContentPageByLanguageAndPath(
language,
path,
'true',
request,
ip,
user
);
} catch (err) {
if ((err as CustomError)?.statusCode === 404) {
return {
exists: false,
title: '',
id: '',
};
}
throw err;
}

return {
exists: !!contentPage,
title: contentPage?.title ?? null,
Expand Down