Skip to content

fix(core): prevent edge dock panel from scrolling its toolbar out of view - #522

Closed
SaKaNa-Y wants to merge 1 commit into
vitejs:mainfrom
SaKaNa-Y:fix/edge-dock-toolbar-scroll
Closed

fix(core): prevent edge dock panel from scrolling its toolbar out of view#522
SaKaNa-Y wants to merge 1 commit into
vitejs:mainfrom
SaKaNa-Y:fix/edge-dock-toolbar-scroll

Conversation

@SaKaNa-Y

@SaKaNa-Y SaKaNa-Y commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

Description

Fixed the issue where opening the Vite / Rolldown Modules Graph Graph view could cause unintended scrolling of the edge dock panel.

Linked Issues

Additional context

@pkg-pr-new

pkg-pr-new Bot commented Aug 8, 2026

Copy link
Copy Markdown

Open in StackBlitz

@vitejs/devtools

npm i https://pkg.pr.new/@vitejs/devtools@522

@vitejs/devtools-kit

npm i https://pkg.pr.new/@vitejs/devtools-kit@522

@vitejs/devtools-oxc

npm i https://pkg.pr.new/@vitejs/devtools-oxc@522

@vitejs/devtools-rolldown

npm i https://pkg.pr.new/@vitejs/devtools-rolldown@522

@vitejs/devtools-vite

npm i https://pkg.pr.new/@vitejs/devtools-vite@522

@vitejs/devtools-vitest

npm i https://pkg.pr.new/@vitejs/devtools-vitest@522

commit: 2f1a93d

@antfubot

Copy link
Copy Markdown
Collaborator

Thanks for this fix!

As of #529, the client UI previously at packages/core/src/client/** (webcomponents, dock, floating popover, json-render, inject runtime, etc.) has moved out of this repo. It now lives upstream in devframe (@devframes/hub-ui / @devframes/json-render-ui), and this repo consumes it as a published dependency instead of owning the source.

Since this PR's changes target code that no longer lives here, we're labeling it devframe. We've opened devframes/devframe#208 to port this fix upstream and credit you as the original author — thank you for the work, and sorry for the churn from the migration. Feel free to pick up the port yourself against devframe (linking back to this PR) if you'd like; otherwise we'll route it through the linked issue.

@antfubot antfubot added the devframe Affected by the devframe/hub-ui migration; fix belongs upstream in devframe label Aug 14, 2026
antfubot added a commit to devframes/devframe that referenced this pull request Aug 14, 2026
…f view

Ports vitejs/devtools#522 by @SaKaNa-Y, adapted for the DockEdge.vue
that landed here in the v0.9 migration. Swaps overflow-hidden for
overflow-clip on the edge dock panel and its content region so the
toolbar can no longer be scrolled out of view when opening a large
view like the Vite/Rolldown Modules Graph.

Co-authored-by: SaKaNa-Y <185575200+SaKaNa-Y@users.noreply.github.com>
@antfu antfu closed this Aug 14, 2026
@SaKaNa-Y
SaKaNa-Y deleted the fix/edge-dock-toolbar-scroll branch August 14, 2026 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devframe Affected by the devframe/hub-ui migration; fix belongs upstream in devframe

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants