Skip to content

fix(core): keep transient-context commands listed in shortcut settings - #524

Closed
SaKaNa-Y wants to merge 1 commit into
vitejs:mainfrom
SaKaNa-Y:fix/close-panel-missing-from-shortcuts
Closed

fix(core): keep transient-context commands listed in shortcut settings#524
SaKaNa-Y wants to merge 1 commit into
vitejs:mainfrom
SaKaNa-Y:fix/close-panel-missing-from-shortcuts

Conversation

@SaKaNa-Y

@SaKaNa-Y SaKaNa-Y commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

Description

Fixed an issue where the Close Panel shortcut entry would incorrectly disappear while opening and closing the Command Palette.

Linked Issues

Additional context

@pkg-pr-new

pkg-pr-new Bot commented Aug 9, 2026

Copy link
Copy Markdown

Open in StackBlitz

@vitejs/devtools

npm i https://pkg.pr.new/@vitejs/devtools@524

@vitejs/devtools-kit

npm i https://pkg.pr.new/@vitejs/devtools-kit@524

@vitejs/devtools-oxc

npm i https://pkg.pr.new/@vitejs/devtools-oxc@524

@vitejs/devtools-rolldown

npm i https://pkg.pr.new/@vitejs/devtools-rolldown@524

@vitejs/devtools-vite

npm i https://pkg.pr.new/@vitejs/devtools-vite@524

@vitejs/devtools-vitest

npm i https://pkg.pr.new/@vitejs/devtools-vitest@524

commit: 5c36d80

@SaKaNa-Y

SaKaNa-Y commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator Author

Sorry, this issue was introduced after my fix for #502. After fixing #502, two side effects appeared: one is this issue, and the other is that users are not warned when binding the same shortcut to commands in different dock modes.

@antfubot

Copy link
Copy Markdown
Collaborator

Thanks for this fix!

As of #529, the client UI previously at packages/core/src/client/** (webcomponents, dock, floating popover, json-render, inject runtime, etc.) has moved out of this repo. It now lives upstream in devframe (@devframes/hub-ui / @devframes/json-render-ui), and this repo consumes it as a published dependency instead of owning the source.

Since this PR's changes target code that no longer lives here, we're labeling it devframe. We've opened devframes/devframe#210 to port this fix upstream and credit you as the original author — thank you for the work, and sorry for the churn from the migration. Feel free to pick up the port yourself against devframe (linking back to this PR) if you'd like; otherwise we'll route it through the linked issue.

@antfubot antfubot added the devframe Affected by the devframe/hub-ui migration; fix belongs upstream in devframe label Aug 14, 2026
@antfu antfu closed this Aug 14, 2026
@SaKaNa-Y
SaKaNa-Y deleted the fix/close-panel-missing-from-shortcuts branch August 14, 2026 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devframe Affected by the devframe/hub-ui migration; fix belongs upstream in devframe

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants