Repository navigation
perf(vite): speed up inspect and stop storing sourcemaps - #617
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-oxc
@vitejs/devtools-rolldown
@vitejs/devtools-vite
@vitejs/devtools-vitest
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Stop recording sourcemaps
result.map. The store no longer stringifies, writes, reads, or parses sourcemaps.sourcemaps, yet every transform paid forJSON.stringify, archive writes, and aJSON.parse+ larger RPC payload on read. Sourcemaps are often the largest field.2. Lower per-hook cost in
hijack.ts.thenchain is only attached when the hook returns a thenable.ctx.filter(or with no env context) call the original hook directly, with no timing.performance.timeOrigin + performance.now(). It is still epoch ms, but with sub-ms precision.async, which added a promise and a microtask to every syncresolveId/load/transformcall (modules × plugins).Date.now()also recorded most hooks as 0ms.3. Keep records when archive writes fail
VDT0004warning is emitted once per archive (docs page + index row added).lastWriteError, and every later record was silently dropped. A transform can't be reproduced, so data must not be lost.