Repository navigation
perf(vite): skip storing unchanged transform results - #618
Open
webfansplz wants to merge 1 commit into
Open
webfansplz wants to merge 1 commit into
webfansplz wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-oxc
@vitejs/devtools-rolldown
@vitejs/devtools-vite
@vitejs/devtools-vitest
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a plugin's
transformreturns code identical to its input (e.g.return codeorreturn { code }), the inspect store wrote a second full copy of that code to the payload archive. This PR reuses the existing payload instead.Changes
writeDataBatch, track the latest code queued for each module in the batch. If a step's result equals that code, point the step at the same payload index instead of pushing a new value.loadresult starts a module's snapshot, so steps never share a payload across transform requests.collectPayloadRangesalready dedupes them.Results from a hook that returns
undefinedwere already skipped, so this only affects the identical-string case. Dedupe is scoped to a single write batch on purpose. Holding each module's latest code across batches would keep it in memory, which the store is designed to avoid.Impact
Measured locally with a synthetic project (5,000 modules × 200 lines, 20 plugins, 5 of which return their input unchanged), median of 10 runs:
The savings scale with how many plugins return their input unchanged.