Repository navigation
perf(vite): cache normalized inspect module ids - #619
Open
webfansplz wants to merge 1 commit into
Open
webfansplz wants to merge 1 commit into
webfansplz wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-oxc
@vitejs/devtools-rolldown
@vitejs/devtools-vite
@vitejs/devtools-vitest
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every recorded hook call normalizes its module id through
getPublicModuleId, so the same id is recomputed once per plugin per hook. For dependency ids this includes apath.relativecall, which made it the most expensive part of the inspect hot path in projects with manynode_modulesmodules. This PR caches the result per environment context.Changes
getPublicModuleIdstores its result in a per-envMap<id, publicId>and returns the cached value on later calls.rootchanges, because the result depends on it.Impact
Measured locally with a synthetic project (5,000 modules × 200 lines, half of them under
node_modules, 20 plugins), median of 10 runs:recordTransform(CPU profile)normalizeModuleId(CPU profile)This roughly halves inspect's overhead on transforms when a project has many dependency modules. With no
node_modulesmodules the saving is small (~20 ms), since only the string replacements are skipped.