Repository navigation
perf(vite): speed up inspect invalidation - #620
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-oxc
@vitejs/devtools-rolldown
@vitejs/devtools-vite
@vitejs/devtools-vitest
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When Vite invalidates a module (for example after a file edit), the inspect store clears that module's records and every record linked to it. To find those links,
invalidateNowrescanned all transforms and resolveId records in the scope, and repeated the scan until no new ids were found. Each invalidation therefore cost time proportional to the whole project, and it ran on the main thread right when the user is waiting for the edit to show up.This PR indexes the records so invalidation only visits the records linked to the invalidated module. The set of cleared records is unchanged.
Changes
invalidateNowwalks the links through these indexes (breadth-first) instead of rescanning the scope until it stops changing.transformsandresolveIdsgoes throughsetTransforms,deleteTransforms,addResolveId, anddeleteResolveIds, so the indexes stay in sync.addInvalidIdandmatchesInvalidhelpers.Impact
Measured locally with a synthetic project (5,000 modules × 200 lines, half under
node_modules, 20 plugins). After all records are written, 200 modules are invalidated and requested again, like an edit once the dev server has settled. Median of 15 runs:Cold-start transform time and the background flush are unchanged. A single small edit invalidates only a few modules, so the gain there is a few milliseconds. It matters most in large projects, after editing a module many others depend on, and after dependency re-optimization.
The indexes use some extra memory: each resolveId record is referenced from four index entries.