Improved exception handling for property type mismatch.

.github/workflows/build-and-deploy.yml

@@ -8,7 +8,7 @@ on:
       - master 
 env:
   APP_NAME: DynamicExpression
-  VERSION: 10.0.3
+  VERSION: 10.0.4
   NUGET_HOST: https://api.nuget.org/v3/index.json
   NUGET_APIKEY: ${{ secrets.NUGET_APIKEY }}
 jobs:

.tests/Tests.DynamicExpression/CriteriaBuilderTest.cs

@@ -612,6 +612,20 @@ public void BuildWhenIntersectsTest()
         Assert.AreEqual("((x.Location != null) AndAlso x.Location.Intersects(POINT (0 0)))", expression.Body.ToString());
     }
 
+    [TestMethod]
+    public void BuildWhenIntersectsAndPropertyTypeMismatchTest()
+    {
+        var criteriaExpression = new CriteriaExpression();
+
+        criteriaExpression.Intersects(nameof(Customer.Name), new Point(0, 0));
+
+        var exception = Assert.ThrowsExactly<ArgumentException>(() => CriteriaBuilder.Build<Customer>(criteriaExpression));
+
+        Assert.IsInstanceOfType<ArgumentException>(exception.InnerException);
+        StringAssert.Contains(exception.Message, nameof(Customer.Name));
+        StringAssert.Contains(exception.Message, nameof(OperationType.Intersects));
+    }
+
     [TestMethod]
     public void BuildWhenWithinTest()
     {

DynamicExpression/CriteriaBuilder.cs

@@ -112,6 +112,18 @@ private static Expression GetExpression(Expression parameter, Criteria criteria,
             }
         }
 
+        try
+        {
+            return CriteriaBuilder.GetExpressionCore(member, value, value2, operationType);
+        }
+        catch (Exception ex) when (ex is ArgumentException or InvalidOperationException && ex is not ArgumentOutOfRangeException)
+        {
+            throw new ArgumentException($"Criteria for property '{name}' cannot be applied: operation '{operationType}' with value type '{value.Type.Name}' is not compatible with the property's type '{member.Type.Name}'.", ex);
+        }
+    }
+
+    private static Expression GetExpressionCore(Expression member, Expression value, Expression value2, OperationType operationType)
+    {
         if (value.Type.IsEnum)
         {
             var expression = Expression.Convert(member, Enum.GetUnderlyingType(value.Type));

DynamicExpression/DynamicExpression.csproj

@@ -15,6 +15,7 @@
 		<PackageTags>Lampda, Expression, Linq, Dynamic, Criteria, Query, Paging, Pagination, Sort, Sorting</PackageTags>
 		<PackageReadmeFile>README.md</PackageReadmeFile>
 		<PackageReleaseNotes>
+			- Improved exception handling for property type mismatch.
 			- Updated NuGets
 		</PackageReleaseNotes>
 		<PackageLicense>https://raw.githubusercontent.com/vivet/DynamicExpression/master/LICENSE</PackageLicense>
@@ -47,7 +48,7 @@
 	</ItemGroup>
 
 	<ItemGroup>
-		<PackageReference Include="Microsoft.SourceLink.GitHub" Version="10.0.301" PrivateAssets="All" />
+		<PackageReference Include="Microsoft.SourceLink.GitHub" Version="10.0.400" PrivateAssets="All" />
 		<PackageReference Include="NetTopologySuite" Version="2.6.0" />
 		<PackageReference Include="Newtonsoft.Json" Version="13.0.4" />
 		<PackageReference Include="NetTopologySuite.IO.GeoJSON" Version="4.0.0" />