Skip to content

fix: remove stray case terminator in clean-helpers.sh - #187

Merged
lukekarrys merged 1 commit into
mainfrom
fix/clean-helpers-syntax
Oct 6, 2026
Merged

lukekarrys merged 1 commit into
mainfrom
fix/clean-helpers-syntax

Conversation

@lukekarrys

@lukekarrys lukekarrys commented Oct 6, 2026 •

Copy link
Copy Markdown
Member

Removing the clean_pacquet_cache case in 2a871b8 left an orphaned ;; in scripts/clean-helpers.sh, so the script fails bash -n (syntax error near unexpected token ';;'). Every benchmark job then failed immediately at hyperfine's --setup (clean_all), e.g. run 37417709604.

Verified bash -n passes for all scripts/*.sh and scripts/variations/*.sh.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Fixed an error that could prevent the cleanup script from running.

Removing the clean_pacquet_cache case in 2a871b8 left an orphaned ';;',
making the script a bash syntax error. Every benchmark job failed at
hyperfine's --setup (clean_all).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a3bc9a46-f1e7-4f65-8970-5d6f35bdef26
📥 Commits

Reviewing files that changed from the base of the PR and between 84ce062 and b88b407.

📒 Files selected for processing (1)
  • scripts/clean-helpers.sh
💤 Files with no reviewable changes (1)
  • scripts/clean-helpers.sh

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The shell argument dispatcher no longer has a duplicate case terminator after the clean_pnpm_cache arm.

Changes

Shell dispatcher

Layer / File(s) Summary
Case terminator correction
scripts/clean-helpers.sh
Removed the extra terminator after clean_pnpm_cache. The clean_vlt_cache arm remains next.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to b88b4

The script’s syntax error is fixed without changing the cache-cleaning commands. No actionable merge risk remains after normal checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: removing a stray case terminator from clean-helpers.sh.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lukekarrys
lukekarrys merged commit 0625fbf into main Oct 6, 2026
57 checks passed
@lukekarrys
lukekarrys deleted the fix/clean-helpers-syntax branch October 6, 2026 05:35

This branch was successfully deployed

1 active deployment
Benchmark — b88b4073 Deployed Oct 6, 2026 by lukekarrys via Run Benchmarks (svelte, ci+setup) #1337
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant