pcsxr: fix build with GCC 14 and PIE crash#61437
Open
Rutpiv wants to merge 1 commit into
Open
Conversation
Rutpiv
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing the changes
Local build testing
Fixes the pcsxr build, broken by GCC 14, and a startup crash present in the current repo binary. The failures predate the nasm update and were discovered while validating dependent packages in #57682.
fix-gcc14-errors.patchaddresses genuine bugs: outdated SDL API calls updated to their current equivalents, and a missingDisplay*cast.-Wno-error=implicit-function-declarationand-Wno-error=incompatible-pointer-typesfor warnings in legacy code that is correct at runtime; patching every occurrence would mean carrying a large downstream diff for an unmaintained upstream.nopie=yes: the x86_64 dynarec assumes 32-bit absolute addressing and asserts at startup when built as PIE. The binary currently in the repo crashes on launch because of this, hence the revbump.