Fsearch: update to 0.3.1. - #61841
Open
RandallFlagg wants to merge 1 commit into
Open
Conversation
RandallFlagg
force-pushed
the
fsearch
branch
2 times, most recently
from
August 7, 2026 08:42
e7011d2 to
d933d4c
Compare
RandallFlagg
marked this pull request as draft
August 8, 2026 10:02
RandallFlagg
marked this pull request as ready for review
August 19, 2026 20:22
Author
|
Hi, Can this workflow be approved? |
Duncaen
requested changes
Sep 4, 2026
Duncaen
left a comment
Member
There was a problem hiding this comment.
- We don't really do conditional patches.
- This should probably not use
*64functions, they are deprecated. - The install message is extremely long, that seems unnecessary.
RandallFlagg
force-pushed
the
fsearch
branch
from
September 6, 2026 21:56
5c69a2e to
fc18828
Compare
Author
|
I updated the patch file. Regarding the install message, what do you suggest instead? It deleted all the rules of the old version. |
Duncaen
requested changes
Sep 6, 2026
Duncaen
left a comment
Member
There was a problem hiding this comment.
Please don't change the maintainer with your first contributions, we would like to see continued maintainership before assigning new maintainers.
RandallFlagg
force-pushed
the
fsearch
branch
from
September 7, 2026 17:18
fc18828 to
9fd7c4a
Compare
Author
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing the changes
Local build testing