Skip to content

llvm19: backport a fix for const analysis crash on fp128 #62448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hosaka wants to merge 1 commit into
base: master
Choose a base branch
from
+18 −1
Open

llvm19: backport a fix for const analysis crash on fp128 #62448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions srcpkgs/llvm19/patches/llvm-007-constantfolding-null-tli-fp128.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
Backport of upstream commit 83a5c7cb62e404a713a35445b755cf0109650279
"[ConstantFolding] Ensure TLI is valid when simplifying fp128 intrinsics"

The inliner's cost analysis calls ConstantFoldCall without a TargetLibraryInfo.
When the host build has logf128, the fp128 folding path dereferences TLI and segfaults.

--- a/llvm/lib/Analysis/ConstantFolding.cpp
+++ b/llvm/lib/Analysis/ConstantFolding.cpp
@@ -2124,7 +2124,7 @@
}

LibFunc Fp128Func = NotLibFunc;
- if (TLI->getLibFunc(Name, Fp128Func) && TLI->has(Fp128Func) &&
+ if (TLI && TLI->getLibFunc(Name, Fp128Func) && TLI->has(Fp128Func) &&
Fp128Func == LibFunc_logl)
return ConstantFoldFP128(logf128, Op->getValueAPF(), Ty);
}
2 changes: 1 addition & 1 deletion srcpkgs/llvm19/template
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Template file for 'llvm19'
pkgname=llvm19
version=19.1.4
revision=8
revision=9
build_wrksrc=llvm
build_style=cmake
_llvm_prefix=lib/llvm/19
Expand Down
Loading