fix: reuse active Vite+ installations for exact versions - #146
Draft
fengmk2 wants to merge 3 commits into
Draft
Conversation
fengmk2
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The action now reuses an active installation when its version matches the requested exact version. This avoids repeated downloads on persistent runners. Fixes #145.
The action checks the payload version, dependency files, directory selection, shims, and Node.js manager configuration before reuse. It adds the selected bin directory to
PATH. Node.js setup and the remaining action steps still run.Reuse requires
VP_DUMP_DIRS, which releases from0.3.0support. Missing files, configuration changes, other active versions, dist-tags, ranges, and preview builds use the existing installer path.The regression test runs setup twice on Linux, macOS, and Windows with
VP_HOMEand split directories. A Linux case also checks XDG paths. The tests check for repeated downloads and changes toinstall.log.All seven reuse cases pass in CI. All 444 unit tests pass. Type checking,
vp run check:fix,vp run build, and workflow validation pass.