fix(global): respect custom VP_HOME by liangmiQwQ · Pull Request #2029 · voidzero-dev/vite-plus

liangmiQwQ · 2026-07-03T05:11:53Z

At present, Vite+ allows users to specific VP_HOME as an installation directory. However, for any future vp runs without manual VP_HOME environment, we still use default ~/.vite-plus or vp's grandparent directory if its name is .vite-plus (It's related to #1185 by me).

It will cause mess, like multiple Vite+ instances, vp binary not finding, packages unusable and a lot of unexpected behavior.

This PR improves all related logic, include:

Set VP_HOME in env files
Improve prompt and implode check related to VP_HOME
Respect VP_HOME in pnpm boostrap-cli at devtime.

The new install.sh prompt looks like that:

🤖 Generated by Codex

netlify · 2026-07-03T05:12:00Z

✅ Deploy Preview for viteplus-preview canceled.

Name	Link
🔨 Latest commit	`4216823`
🔍 Latest deploy log	https://app.netlify.com/projects/viteplus-preview/deploys/6a49dfab6600b700082b43a4

liangmiQwQ · 2026-07-03T05:12:26Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 410a38e18e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

liangmiQwQ · 2026-07-03T05:44:10Z

@codex review

chatgpt-codex-connector · 2026-07-03T05:49:47Z

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: 7e3e24e536

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

liangmiQwQ · 2026-07-03T05:57:17Z

@fengmk2 Worth mentioning: after this change, Vite+ will start injecting VP_HOME in shellrc, just like Volta. (VOLTA_HOME). It may also help to check whether Vite+ is installed for other tools :)

fengmk2 · 2026-07-03T05:59:44Z

@fengmk2 Worth mentioning: after this change, Vite+ will start injecting VP_HOME in shellrc, just like Volta. (VOLTA_HOME). It may also help to check whether Vite+ is installed for other tools :)

Good news, maybe after your pr merge, my one can be closed #1958 😄

fengmk2 · 2026-07-03T06:01:47Z

@nekomoyi @naokihaba I need your help to see if this added environment variable will have any side effects.

liangmiQwQ · 2026-07-03T06:02:00Z

Good news, maybe after your pr merge, my one can be closed #1958 😄

Oh? I haven't seen it, I would take a look at it later.

fengmk2 · 2026-07-03T06:19:13Z

If I have previously installed vite-plus, and this time I reinstall it and set VP_HOME to a new directory, should we prompt the user whether they need to remove the previous ~/.vite-plus directory?

liangmiQwQ · 2026-07-04T06:13:36Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 003cc49858

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

liangmiQwQ · 2026-07-04T08:42:51Z

@codex review

chatgpt-codex-connector · 2026-07-04T08:50:35Z

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: 40bb28be7d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

liangmiQwQ · 2026-07-04T08:54:12Z

This PR lets me run vp implode for the first time lol.

fengmk2

@liangmiQwQ Nice improve!

I will do a round simplify before I merge.

…pers - implode: normalize source-line args to forward slashes once instead of enumerating separator variants per root; drop path_ref_with_backslashes, push_path_ref and the env.nu special case; document the matcher's multi-install rationale and writer cross-references - home: share VP_BINARY_NAME from vite_shared (re-exported by vite_setup), avoid the per-PATH-entry clone, and drop redundant test guards - env/setup: reuse render_home_relative_path for the Nu VP_HOME and explain why it must stay absolute - install.sh: reuse abbreviate_path for the shims prompt, simplify normalize_existing_dir, use command -v directly - install.ps1: reuse the USERPROFILE-to-~ display idiom, drop the dead .Source fallback and redundant TrimEnd calls

fengmk2 · 2026-07-04T14:37:00Z

@liangmiQwQ I'm done, back to your control.

fengmk2 · 2026-07-04T14:38:01Z

@liangmiQwQ I ran it once under Windows and haven't found any issues so far.

liangmiQwQ · 2026-07-04T14:53:20Z

@fengmk2 @nekomoyi @naokihaba Thank the team for inspecting, reviewing and simplifying!

I'm a bit sleepy tonight, and I will take a look to know if there is anything need doing on my side tomorrow.

@fengmk2 And I left a comment in your pull request, you can take a look #1958 (comment)

fengmk2 · 2026-07-05T04:58:31Z

GO!

liangmiQwQ added 6 commits July 3, 2026 09:54

fix: respect VP_HOME in Node manager prompts

02111ae

fix: inject custom VP_HOME in env setup

fcc58f0

chore: drop node-based vp home inference

02aa092

fix: fix global vp implode cleanup matching

f4d0a51

chore: use VP_HOME for global CLI install

5f6ac87

update document

db7166a

Merge branch 'main' into fix/custom-vp-home-broken

410a38e

chatgpt-codex-connector Bot reviewed Jul 3, 2026

View reviewed changes

Comment thread crates/vite_global_cli/src/commands/env/setup.rs Outdated

liangmiQwQ added 2 commits July 3, 2026 13:38

wip

888ee44

wip

7e3e24e

liangmiQwQ marked this pull request as ready for review July 3, 2026 05:52

fengmk2 requested review from naokihaba and nekomoyi July 3, 2026 06:01

fengmk2 added test: e2e Auto run e2e tests test: install-e2e run vite install e2e test test: create-e2e Run `vp create` e2e tests test: sfw labels Jul 3, 2026

This was referenced Jul 3, 2026

Infra: refactor global snap test #2032

Open

feat(cli): advertise VP_USER_AGENT to child processes #1958

Draft

liangmiQwQ added 2 commits July 3, 2026 20:37

wip

43f7d23

Merge branch 'main' into fix/custom-vp-home-broken

bd7532a

wip

003cc49

chatgpt-codex-connector Bot reviewed Jul 4, 2026

View reviewed changes

Comment thread crates/vite_shared/src/home.rs Outdated

Comment thread packages/cli/install.sh

Comment thread packages/cli/install.sh

liangmiQwQ added 6 commits July 4, 2026 14:28

fix

7fdced9

wip

db7ed20

CI guard

67e0f6d

wip

c0163b2

wip

1e63a6c

wip

40bb28b

liangmiQwQ marked this pull request as ready for review July 4, 2026 08:53

liangmiQwQ and others added 3 commits July 4, 2026 18:41

Merge branch 'main' into fix/custom-vp-home-broken

05645db

Merge branch 'main' into fix/custom-vp-home-broken

bd66115

Merge branch 'main' into fix/custom-vp-home-broken

e1bba3d

fengmk2 approved these changes Jul 4, 2026

View reviewed changes

naokihaba approved these changes Jul 4, 2026

View reviewed changes

Comment thread crates/vite_global_cli/src/commands/env/setup.rs Outdated

Comment thread crates/vite_global_cli/src/commands/env/setup.rs Outdated

nekomoyi approved these changes Jul 4, 2026

View reviewed changes

naokihaba mentioned this pull request Jul 4, 2026

Add a real Nushell test for generated env.nu #2049

Open

liangmiQwQ added 2 commits July 5, 2026 08:28

wip

139248a

Merge branch 'main' into fix/custom-vp-home-broken

4216823

fengmk2 merged commit 638c447 into voidzero-dev:main Jul 5, 2026
112 of 113 checks passed

liangmiQwQ deleted the fix/custom-vp-home-broken branch July 5, 2026 05:03

liangmiQwQ mentioned this pull request Jul 5, 2026

Do not change system configuration without asking the user #1985

Closed

4 tasks

Uh oh!

Conversation

liangmiQwQ commented Jul 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify Bot commented Jul 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for viteplus-preview canceled.

Uh oh!

liangmiQwQ commented Jul 3, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

liangmiQwQ commented Jul 3, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 3, 2026

Uh oh!

liangmiQwQ commented Jul 3, 2026

Uh oh!

fengmk2 commented Jul 3, 2026

Uh oh!

fengmk2 commented Jul 3, 2026

Uh oh!

liangmiQwQ commented Jul 3, 2026

Uh oh!

fengmk2 commented Jul 3, 2026

Uh oh!

liangmiQwQ commented Jul 4, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

liangmiQwQ commented Jul 4, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 4, 2026

Uh oh!

liangmiQwQ commented Jul 4, 2026

Uh oh!

fengmk2 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

fengmk2 commented Jul 4, 2026

Uh oh!

fengmk2 commented Jul 4, 2026

Uh oh!

liangmiQwQ commented Jul 4, 2026

Uh oh!

fengmk2 commented Jul 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

liangmiQwQ commented Jul 3, 2026 •

edited

Loading

netlify Bot commented Jul 3, 2026 •

edited

Loading