fix(upgrade): isolate pnpm install from parent workspaces - #2644
Merged
Conversation
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://fix-upgrade-parent-workspace-viteplus-dev.voidzero-docs.workers.dev (commit f4769a8)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
Contributor
CLI artifact sizes (
|
| Artifact | Format | Base | PR | Change |
|---|---|---|---|---|
packages/cli/dist |
Directory total | 2.14 MiB | 2.14 MiB | 0 B (0.00%) |
packages/core/dist |
Directory total | 3.92 MiB | 3.92 MiB | 0 B (0.00%) |
| Combined package dist | Directory total | 6.06 MiB | 6.06 MiB | 0 B (0.00%) |
vp (Linux x64) |
Binary | 11.14 MiB | 11.14 MiB | 0 B (0.00%) |
vp (Linux x64) |
gzip -9 | 4.82 MiB | 4.82 MiB | +121 B (+0.00%) |
| NAPI (Linux x64) | Binary | 32.03 MiB | 32.03 MiB | 0 B (0.00%) |
| NAPI (Linux x64) | gzip -9 | 12.64 MiB | 12.64 MiB | 0 B (0.00%) |
vp (macOS ARM64) |
Binary | 8.30 MiB | 8.30 MiB | 0 B (0.00%) |
vp (macOS ARM64) |
gzip -9 | 4.19 MiB | 4.19 MiB | +111 B (+0.00%) |
| NAPI (macOS ARM64) | Binary | 39.61 MiB | 39.61 MiB | 0 B (0.00%) |
| NAPI (macOS ARM64) | gzip -9 | 16.96 MiB | 16.96 MiB | -1 B (-0.00%) |
vp (Windows x64) |
Binary | 9.01 MiB | 9.01 MiB | 0 B (0.00%) |
vp (Windows x64) |
gzip -9 | 3.93 MiB | 3.93 MiB | +116 B (+0.00%) |
| NAPI (Windows x64) | Binary | 26.92 MiB | 26.92 MiB | 0 B (0.00%) |
| NAPI (Windows x64) | gzip -9 | 10.74 MiB | 10.74 MiB | -6 B (-0.00%) |
| Trampoline (Windows x64) | Binary | 13.50 KiB | 13.50 KiB | 0 B (0.00%) |
| Trampoline (Windows x64) | gzip -9 | 7.03 KiB | 7.03 KiB | 0 B (0.00%) |
| Installer (Windows x64) | Binary | 4.52 MiB | 4.52 MiB | 0 B (0.00%) |
| Installer (Windows x64) | gzip -9 | 2.11 MiB | 2.11 MiB | -77 B (-0.00%) |
fengmk2
force-pushed
the
fix/upgrade-parent-workspace
branch
from
September 10, 2026 15:06
7064ecd to
8377415
Compare
cpojer
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vp upgradecan use a parentpnpmworkspace and fail when its lockfile is stale. With a valid lockfile, it can report success without its own dependencies.The installer now adds
--ignore-workspacetopnpm install. Two snapshot tests check the global package and the unchanged parent workspace for both lockfile states.Fixes #2639.