fix(env): isolate direct shims from package manager selection - #2658
fix(env): isolate direct shims from package manager selection#2658liangmiQwQ wants to merge 5 commits into
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9ef8a3ea0e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fengmk2
added
test: e2e
There was a problem hiding this comment.
@liangmiQwQ LGTM, when the other pr is ready, I will merged them both.
2 participants
Stack 1/2. Merge this PR first, then #2659 (stack 2/2). Both PRs target
mainbecause the branches are hosted in a fork. #2659 currently includes this layer and links to its incremental diff.VP_PACKAGE_MANAGERcurrently changes both the manager used byvp installand the version used by a directly invoked matching shim. This PR makes direct shims ignore that variable while preserving its effect onvp installand other package-manager commands.For example, with a project pin of
pnpm@10.18.0andVP_PACKAGE_MANAGER=pnpm@10.19.0, Vite+ selects 10.19.0 forvp installand 10.18.0 for the pnpm shim. The existing session-file, project, and default resolution paths remain available to shims.This layer adds no environment variables and does not change
vp env use. Its shell-wrapper version switching is restored through independent version variables in stack 2/2, so the two layers should be landed together in order.🤖 Generated with Codex