Repository navigation
fix(skills): support Skill Space sharing signed URL fallback - #1214
Merged
Rhosmarie merged 2 commits intoNov 6, 2026
Merged
Conversation
zakahan
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Skill Space skill materialization when legacy
TosPathpoints to a sharing-bucket object key that cannot be read directly with TOS SDK credentials.This change now supports both cases:
TosPathis already an HTTPS signed TOS ZIP URL: download it directly.TosPathis an object key and direct TOS download is denied: callGenTempTosObjectDownloadUrlSharing, readResult.SignedUrl, and reuse the signed URL ZIP downloader.Verification
uv run --extra dev pytest tests/skills/test_adk_skill_materializer.py tests/skills/test_skill_space_policy.py tests/skills/test_adk_skill_registry.py -q52 passeduv run --extra dev pre-commit run --all-filesss-yey3lbgruoq7vcs7xlp4pdf: download and ADK load passedpptx: download and ADK load passedcode-review-and-quality: download and ADK load passedhumanizer: zip download passed, ADK frontmatter validation failed; separate skill metadata issue