Skip to content

Fix the manual_map lint in TrustedLenAdapter::next #10597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robert3005 merged 1 commit into from
Oct 19, 2026
Merged

Fix the manual_map lint in TrustedLenAdapter::next #10597

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 15 additions & 21 deletions vortex-buffer/src/trusted_len.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,29 +30,23 @@ impl<I: Iterator> Iterator for TrustedLenAdapter<I> {

#[inline]
fn next(&mut self) -> Option<Self::Item> {
match self.inner.next() {
None => {
#[cfg(debug_assertions)]
{
assert_eq!(
self.len, self.count,
"TrustedLenAdapter: iterator ended early"
);
}
None
}
Some(item) => {
#[cfg(debug_assertions)]
{
self.count += 1;
assert!(
self.count <= self.len,
"TrustedLenAdapter: iterator yielded more items than promised"
);
}
Some(item)
let item = self.inner.next();
#[cfg(debug_assertions)]
{
if item.is_some() {
self.count += 1;
assert!(
self.count <= self.len,
"TrustedLenAdapter: iterator yielded more items than promised"
);
} else {
assert_eq!(
self.len, self.count,
"TrustedLenAdapter: iterator ended early"
);
}
}
item
}

#[inline]
Expand Down
Loading