Skip to content

Add StandardSum: a sum aggregate where zero valid values yields null#8705

Open
mhk197 wants to merge 13 commits into
developfrom
mk/sum-empty-null
Open

Add StandardSum: a sum aggregate where zero valid values yields null#8705
mhk197 wants to merge 13 commits into
developfrom
mk/sum-empty-null

Consolidate StandardSum tests: parameterize null-for-empty matrix, dr…

420719a
Select commit
Loading
Failed to load commit list.
CodSpeed HQ / CodSpeed Performance Analysis failed Jul 12, 2026 in 0s

5 benchmarks regressed

⚡ 11 improved benchmarks
❌ 5 regressed benchmarks
✅ 1621 untouched benchmarks
🆕 12 new benchmarks
⏩ 38 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation fsl_sum_small 57.6 µs 81.6 µs -29.47%
Simulation chunked_varbinview_canonical_into[(1000, 10)] 154.6 µs 190.7 µs -18.95%
Simulation listview_sum_small 73.4 µs 86.2 µs -14.76%
Simulation slice_empty_vortex 339.4 ns 397.8 ns -14.66%
Simulation take_map[(0.1, 1.0)] 1.6 ms 1.9 ms -13.24%
Simulation bitwise_not_vortex_buffer_mut[128] 244.4 ns 186.1 ns +31.34%
Simulation bitwise_not_vortex_buffer_mut[1024] 304.7 ns 246.4 ns +23.68%
Simulation list_sum_large 135.7 ms 111.6 ms +21.57%
Simulation listview_sum_large 108.1 ms 89.1 ms +21.34%
Simulation chunked_varbinview_into_canonical[(1000, 10)] 205.9 µs 170.3 µs +20.93%
Simulation bitwise_not_vortex_buffer_mut[2048] 398.6 ns 340.3 ns +17.14%
Simulation encode_varbin[(10000, 2)] 977.1 µs 836.4 µs +16.83%
Simulation list_sum_nullable_elements_large 493.8 ms 426.9 ms +15.67%
Simulation sum_i32_nullable_all_valid 41.5 µs 36.8 µs +12.92%
Simulation list_sum_nullable_elements_medium 4.9 ms 4.3 ms +11.83%
Simulation compare_int_constant 298.7 µs 268.8 µs +11.11%
🆕 Simulation standard_sum_f64_all_valid N/A 61.4 µs N/A
🆕 Simulation standard_sum_f64_clustered_nulls N/A 89.3 µs N/A
🆕 Simulation standard_sum_i32_clustered_nulls N/A 86.2 µs N/A
🆕 Simulation standard_sum_i32_nullable_all_valid N/A 57.7 µs N/A
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing mk/sum-empty-null (420719a) with develop (d2b2378)

Open in CodSpeed

Footnotes

  1. 38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.