Skip to content

Simplify StatsRewriteCtx rules by leveraging BoundExpressions #9643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robert3005 wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Simplify StatsRewriteCtx rules by leveraging BoundExpressions #9643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
174e9d1
Simplify StatsRewriteCtx rules by leveraging BoundExpressions
robert3005 Aug 26, 2026
e05e7ea
less
robert3005 Aug 26, 2026
15c78d1
simpler
robert3005 Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions vortex-array/src/stats/rewrite.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,11 +101,6 @@ impl<'a> StatsRewriteCtx<'a> {
self.session
}

/// Return the dtype of `expr` within this rewrite scope.
pub fn return_dtype(&self, expr: &BoundExpression) -> VortexResult<DType> {
Ok(expr.dtype().clone())
}

/// Rewrite `expr` into a stats-backed falsifier.
pub fn falsify(&self, expr: &BoundExpression) -> VortexResult<Option<BoundExpression>> {
self.ensure_predicate(expr)?;
Expand All @@ -118,8 +113,9 @@ impl<'a> StatsRewriteCtx<'a> {
rewrite(expr, self, StatsRewriteRule::satisfy)
}

#[inline]
fn ensure_predicate(&self, expr: &BoundExpression) -> VortexResult<()> {
let dtype = self.return_dtype(expr)?;
let dtype = expr.dtype();
vortex_ensure!(
matches!(dtype, DType::Bool(_)),
"Stats rewrites require a boolean predicate, got {dtype}",
Expand Down
Loading
Loading