Skip to content

Clarify Boolean collection code generation - #9676

Open
connortsui20 wants to merge 2 commits into
developfrom
ct/collect-bool-docs
Open

Clarify Boolean collection code generation#9676
connortsui20 wants to merge 2 commits into
developfrom
ct/collect-bool-docs

Conversation

@connortsui20

@connortsui20 connortsui20 commented Aug 27, 2026

Copy link
Copy Markdown
Member

Summary

Clarifies the callback contract and code-generation behavior of BitBuffer::collect_bool, including the remaining AVX-512 mask-to-bytes-to-mask conversion tracked by LLVM #219235.

Changes

Documents when to use the inlined and runtime-multiversioned collectors, and replaces the duplicate BitBufferMut explanations with links to the canonical BitBuffer documentation.

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20 connortsui20 added the changelog/docs A docs change label Aug 27, 2026
@codspeed-hq

codspeed-hq Bot commented Aug 27, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 20.46%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 1 improved benchmark
✅ 2138 untouched benchmarks
⏩ 106 skipped benchmarks1
🗄️ 4 archived benchmarks run2

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime arrow_checked_add_u32_avx2[16384] 21.3 µs 17.7 µs +20.46%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ct/collect-bool-docs (81fa252) with develop (f880575)

Open in CodSpeed

Footnotes

  1. 106 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. 4 benchmarks were run, but are now archived. If they were deleted in another branch, consider rebasing to remove them from the report. Instead if they were added back, click here to restore them.

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20
connortsui20 enabled auto-merge (squash) August 27, 2026 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/docs A docs change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant