Skip to content

Prepare benchmark-specific data formats - #9685

Open
palaska wants to merge 1 commit into
developfrom
bp/fix-data-gen-format-preparation
Open

Prepare benchmark-specific data formats#9685
palaska wants to merge 1 commit into
developfrom
bp/fix-data-gen-format-preparation

Conversation

@palaska

@palaska palaska commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

data-gen now calls each benchmark's prepare_format hook after standard conversions. This creates benchmark-specific formats through vx-bench prepare-data.

Validation:

  • cargo +nightly fmt --all --check
  • cargo clippy -p vortex-bench --all-targets --all-features -- -D warnings

Agent: Codex.

Signed-off-by: Baris Palaska <barispalaska@gmail.com>
@palaska palaska added the changelog/fix A bug fix label Aug 28, 2026
@codspeed-hq

codspeed-hq Bot commented Aug 28, 2026

Copy link
Copy Markdown

Merging this PR will regress 1 benchmark

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 2 improved benchmarks
❌ 1 regressed benchmark
✅ 2154 untouched benchmarks
⏩ 106 skipped benchmarks1
🗄️ 4 archived benchmarks run2

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation cold_misaligned[(16, 64)] 345.6 µs 392.8 µs -12.02%
WallTime arrow_checked_add_u32_avx2[16384] 21.3 µs 17.7 µs +20.26%
WallTime words_gather_scalar_avx2[65536] 9.4 µs 8.3 µs +13.33%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing bp/fix-data-gen-format-preparation (f15b631) with develop (68e2aee)

Open in CodSpeed

Footnotes

  1. 106 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. 4 benchmarks were run, but are now archived. If they were deleted in another branch, consider rebasing to remove them from the report. Instead if they were added back, click here to restore them.

@palaska
palaska enabled auto-merge (squash) August 28, 2026 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant